Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dx): adds a systemd unit workaround service to relabel libvirt files #1586

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented Aug 9, 2024

Almost all users need to run a restorecon on one or two of these directories when creating a VM for the first time.
I'm hoping this will solve these issues automatically on boot.

I planned to not create the /var/log directory, but restorecon failed to set the correct labels on the directory, and it required the user fail to create a VM (which creates the log dir), then reboot. For the sake of a couple bytes, we might as well create the log directory on boot.

Almost all users need to run a restorecon on one or two of these directories.  I'm hoping this will solve these issues automatically on boot.
@p5 p5 requested a review from castrojo as a code owner August 9, 2024 19:53
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dx Developer Experience Image specific labels Aug 9, 2024
@p5 p5 marked this pull request as draft August 9, 2024 20:02
@p5 p5 marked this pull request as ready for review August 9, 2024 20:30
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@castrojo castrojo merged commit e023b60 into main Aug 14, 2024
54 checks passed
@castrojo castrojo deleted the restorecon-libvirt-files-on-boot branch August 14, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants